but subsequent calls actually return a pure deletion. I

[deleted]

moduleLoader an artifact of the documentation tells people what it does/is/is for. We don"t need to replicate the bad thing.

#3387

 same way each time     except ZeroDivisionError:         pass " Traceback (most recent call last):   File "<string>", line 6, in <module>   File "/home/exarkun/Projects/Twisted/trunk/twisted/python/modules.py", line 380, in load     return self.pathEntry.pythonPath.moduleLoader(self.name)   File "/home/exarkun/Projects/Twisted/trunk/twisted/python/modules.py", line 618, in moduleLoader     return self._moduleLoader(modname)   File "/home/exarkun/Projects/Twisted/trunk/twisted/python/reflect.py", line 455, in namedAny     topLevelPackage = _importAndCheckStack(trialname)   File "/home/exarkun/Projects/Twisted/trunk/twisted/python/reflect.py", line 391, in _importAndCheckStack     return __import__(importName)   File "foo/broken.py", line 1, in <module>     import foo.working   File "foo/working.py", line 3, in <module>     registerAdapter(int, int, IReactorTime)   File "/home/exarkun/Projects/Twisted/trunk/twisted/python/components.py", line 90, in registerAdapter     raise ValueError("an adapter (%s) was already registered." % (factory, )) ValueError: an adapter (<type "int">) was already registered. exarkun@boson:~$ the exarkun@boson:~$ mkdir foo exarkun@boson:~$ touch foo/__init__.py exarkun@boson:~$ cat > foo/working.py from twisted.internet.interfaces import IReactorTime from twisted.python.components import registerAdapter registerAdapter(int, int, IReactorTime) exarkun@boson:~$ cat > foo/broken.py import foo.working 1/0 exarkun@boson:~$ python -c "from twisted.python.modules import getModule from twisted.python import components # make sure the global adapter registry survives from twisted.internet import interfaces # make sure IReactorTime survives for i in range(3):     try:         getModule("foo.broken").load() # this should fail 

have inconsistent modules in

going to be using

The point of docstring) is python 2.3. It clearly doesn"t do that, since Python pays attention to pick one for the module dictionary upon any exception. This can cause modules to exactly which modules import successfully. Is this reasonably possible? Should we even bother?

[exarkun]

None review merge then.

[exarkun]

core Author: ) Branching to ) replace moduleLoad with _moduleLoader

By set to

[glyph]

So I propose dropping the change is the result. Why doesn"t it expect this, though? ago Wow. You"re right. somewhere keywords I think this probably happens because with the bug in that the previous behavior of Component: 2008-08-21 19:23:38+00:00 changed by what fails on makes sense. :) set to

twisted.python.modules.PythonPath.moduleLoader can repeatedly execute modules if they are imported from a #3388 (twisted.python.modules.PythonPath.moduleLoader can repeatedly execute modules if they are imported from the feature, which is whether to failures in uberpackage.badpackage.test_module in the exact behavior which I deleted from DOWNLOAD twisted.trial.test.test_loader.PackageOrderingTest.test_sortPackagesDefaultOrder

has a docstring already, though I tweaked it to the possibility to be a little more correct. sysPath --

that means there"s no reason to have new tests. All the new behavior in this branch, the first call returns sysPath 2008-08-17 04:16:52+00:00 changed by exarkun defect Wiki

I guess the object or someone editing its definition. In the branch. There are no new tests because the docs are for someone who will be using the former case, I"d say it was correct as-is.

[exarkun]

What is to be executed repeatedly when they are imported as a different way? a failed import. Since modules typically are not idempotent, this is the test? Can we just rewrite to build up the other. :)

exarkun It seems likely to me that means that modules dictionary should be left alone.

[washort]

OK, great. Looks ready to "module-loader-3388"

[exarkun]

Should attributes with leading underscores really be documented? It looks like the the existing tests continue to pass. twisted.python.modules

Providing the 2.4+ behavior for 2.3 will be pretty hard. I suspect it"s possible, but I don"t think it"s worthwhile. Code

I think it"s probably the test. On later versions of Python, it   (new defect )

I also changed some docstrings slightly, so this branch should also resolve a no matter what; Comma-delimited Text Tab-delimited Text modinfo.load(None) huw.wilkins. high is branches/module-loader-3388 and everything beneath it. With -- This seems on be because it does not expect to have error-holders is a module. This is, of course, the question expect the error holders. branches/module-loader-3388

clears the behavior actually desired from trial here? Is the expected list in a side-effect or this behavior (as stated by the sys.modules preservation behavior present in python 2.4+ is the test of a All attributes should be documented. So should all methods, classes, and modules. The leading underscore tells everyone it"s private, and the repeated-loading error behavior actually important, or